New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rounding issue in n_components #507

Merged
merged 1 commit into from Nov 9, 2014

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Nov 9, 2014

Unfortunately I can't remember the details of where this bug arrises, but the int() cast in this PR fixes a serialisation bug in PCA. Secondly, I move _n_components to _n_active_components which is clearer in it's meaning.

@jabooth jabooth added the in progress label Nov 9, 2014

jabooth added a commit that referenced this pull request Nov 9, 2014

Merge pull request #507 from jabooth/pca_fixes
fix rounding issue in n_components

@jabooth jabooth merged commit 98d71e5 into menpo:master Nov 9, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Nov 9, 2014

@jabooth jabooth deleted the jabooth:pca_fixes branch Nov 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment