New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menpo.io add pickle support, move to pathlib #521

Merged
merged 8 commits into from Dec 3, 2014

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Dec 3, 2014

Four things in this PR:

  1. Added menpo.io.import_pickle{s}, menpo.io.export_pickle
  2. Moved menpo.io.base to use pathlib.Path objects
  3. Flipped exporters so signature is (obj, fp) instead of (fp, obj)
  4. Removed three unneeded functions from menpo.io.base (they are only needed in menpo3d)

I've updated tests but not yet added new ones for pickle. Note that menpo3d will need a PR to be brought inline in terms of exporting style and using Path objects.

@jabooth jabooth added the in progress label Dec 3, 2014

jabooth added a commit that referenced this pull request Dec 3, 2014

Merge pull request #521 from jabooth/export_pickle
menpo.io add pickle support, move to pathlib

@jabooth jabooth merged commit 4b3534c into menpo:master Dec 3, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Dec 3, 2014

@jabooth jabooth deleted the jabooth:export_pickle branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment