Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
LandmarkGroup.init_with_all_label, init_* convenience constructors #533
@patricksnape looks great. One comment - I like the pattern of
We presently have three
I believe I chose these signatures, and mainly went for obviousless and readability.
We could set it as
If so, maybe there is an argument for updating those signatures above to match that style? (e.g.
Another candidate would be
Haha well let's leave that to one side then... ;)
Surely there is merit in it being
There is nothing wrong with
I find that reads rather well.. although I accept maybe I am used to this from iOS development. Does it not exactly describe the functionality though?
No I don't think so. We aren't making an 'Angle', we are making a
Meh, this is becoming a rabbit hole discussion about the merits of naming patterns. In short, I don't mind, I just prefer non 'sentence' methods like our
In short, I don't really mind, I defer the decision to you. This pull request will wait until 0.4.0 is released anyway.