New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJSON v2 #540

Merged
merged 2 commits into from Jan 27, 2015

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Jan 23, 2015

This PR updates menpo to use LJSON v2. Some notes:

  1. menpo.io.export_landmark_file{s}() now always exports the v2 format.
  2. menpo.io.import_landmark_file{s}() for now imports both formats, but will raise a Deprecation error when v1 landmark files are imported.
  3. .tojson() on shapes is now reserved for LJSON only. Only PointCloud, PointGraph, and TriMesh have this method now. Note that TriMesh saves out as a PointGraph (so if you load a saved out TriMesh-backed LJSON file, your TriMesh will now be a point graph.
  4. lenna.pts is now lenna.ljson so we have an example of LJSON v2 with the menpo data dir.

@jabooth jabooth added the in progress label Jan 23, 2015

@jabooth jabooth referenced this pull request Jan 26, 2015

Merged

move to API v2 (WIP) #13

5 of 5 tasks complete
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jan 27, 2015

Seems good to me! +1

patricksnape added a commit that referenced this pull request Jan 27, 2015

@patricksnape patricksnape merged commit 433df01 into menpo:master Jan 27, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@patricksnape patricksnape deleted the jabooth:ljson branch Jan 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment