New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different marker colour per label #545

Merged
merged 2 commits into from Feb 2, 2015

Conversation

Projects
None yet
3 participants
@nontas
Member

nontas commented Feb 2, 2015

Until now, we were only supporting different colouring for the lines of each label of a landmark group. This PR changes this in order to be able to define a different marker_face_colour and marker_edge_colour per label of each group. It also corrects the way the legend is created so that it takes into account the above change. Finally, it fixes a bug in viewmatplotlib methods regarding the render_axes parameter.

Note that in the future, one could also define different line_style, line_width, marker_edge_width,marker_styleandmarker_sizeper label. However, it's not a priority for now. Also, the widgets are not updated: you can define a differentline_colour` per label but not marker colour. I will fix this in the future, but again it's not a priority for the next release.

nontas added some commits Feb 2, 2015

adds ability to set different marker colour per label
Till now one could only different a different
line_colour per label. This commit changes this to also
support markers. Note that the widgets are not
updated yet.

@jabooth jabooth added the in progress label Feb 2, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 2, 2015

+1 I will fix the docs on my doc fixing branch

nontas added a commit that referenced this pull request Feb 2, 2015

Merge pull request #545 from nontas/marker_multiple_colouring
Different marker colour per label

@nontas nontas merged commit 6c417bd into menpo:master Feb 2, 2015

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Feb 2, 2015

@nontas nontas deleted the nontas:marker_multiple_colouring branch Feb 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment