New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: remove incorrect tojson() methods #551

Merged
merged 1 commit into from Feb 7, 2015

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Feb 7, 2015

Unfortunately we didn't fully clean up the old tojson() methods when moving to v2. This is a major bug - it can cause the creation of incorrect LJSON files which are for instance invalid with the landmarker.

We have to merge this and immediately issue a bug fix release.

@jabooth jabooth added the in progress label Feb 7, 2015

Dictionary with ``adjacency_array`` key. Suitable or use in the by
the `json` standard library package.
"""
return {'adjacency_array': self.adjacency_array.tolist()}

This comment has been minimized.

@jabooth

jabooth Feb 7, 2015

Member

this is the real problem - it causes the creation of an invalid LJSON file (uses 'adjacency_array' instead of 'connectivity' for the connection information)

jabooth added a commit that referenced this pull request Feb 7, 2015

Merge pull request #551 from jabooth/HOTFIXljsonv2
HOTFIX: remove incorrect tojson() methods

@jabooth jabooth merged commit 2686628 into menpo:master Feb 7, 2015

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Feb 7, 2015

@jabooth jabooth deleted the jabooth:HOTFIXljsonv2 branch Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment