New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel roll #558

Merged
merged 4 commits into from Feb 20, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Feb 20, 2015

New function for getting access to the rolled channels.

Also, optimise the as_greyscale method by caching the inverted matrix. Order of magnitude speedup.

patricksnape added some commits Feb 20, 2015

Optimise as_greyscale
Cache the inverted matrix, it is now an order of magnitude faster.
Add new method for rolling the channels
Gives easy access to the rolled channels, which makes it simpler
to pass our images to other frameworks.

Also, ensure that the rolled pixels are c-contiguous.
Move to lazy calculation for luminosity
Make it a global, similar to our lazy importing
@jabooth

This comment has been minimized.

Member

jabooth commented Feb 20, 2015

+1

jabooth added a commit that referenced this pull request Feb 20, 2015

@jabooth jabooth merged commit 008f7ea into menpo:master Feb 20, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Feb 20, 2015

@jabooth jabooth deleted the patricksnape:channel_roll branch Feb 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment