New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes #560

merged 4 commits into from Mar 3, 2015


None yet
2 participants

patricksnape commented Mar 3, 2015

This is a bunch of fixes I've had lying around, uncommited, including:

  1. Fix 3D Ljson importing
  2. Fix trim_components on PCA
  3. Fix setting None key on the landmark manager
  4. Making mean_pointcloud faster

patricksnape added some commits Mar 3, 2015

Fix importing of 3D lsjon
Accidentically hardcoded a 2D value, this is now fixed to be
Enforce the None key for landmarks
None has a special meaning for landmark groups, you shouldn't
be able to save a landmark group at key 'None'.
Fix trim components for PCA
A view was being returned, now the copy (much like image crop)
enforces that the data is collected.
Update mean_pointcloud to be faster
This is actually faster than using numpy. It is also MUCH
faster if it gets jitted by something like pypy or numba.

This comment has been minimized.


jabooth commented Mar 3, 2015

great little improvements, +1

jabooth added a commit that referenced this pull request Mar 3, 2015

@jabooth jabooth merged commit d4f3ed8 into menpo:master Mar 3, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@jabooth jabooth deleted the patricksnape:assorted_fixes branch Mar 3, 2015

@jabooth jabooth removed the in progress label Mar 3, 2015

@patricksnape patricksnape restored the patricksnape:assorted_fixes branch Mar 5, 2015

@patricksnape patricksnape deleted the patricksnape:assorted_fixes branch Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment