New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new point_in_pointcloud kwarg to constrain #569

Merged
merged 1 commit into from Mar 31, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Mar 26, 2015

This new kwarg determines how the point in pointcloud test is
performed. By default it is still PWA, but there is a new, fast
method provided by matplotlib that does a basic convex hull
check, where points on the boundary are counted as outside
the hull.

Also, the trilist argument is deprecated and raises a warning.

Finally, the point_in_pointcloud can actually take an
arbitrary callable for overriding the test.

Add new point_in_pointcloud kwarg to constrain
This new kwarg determines how the point in pointcloud test is
performed. By default it is still PWA, but there is a new, fast
method provided by matplotlib that does a basic convex hull
check, where points on the boundary are counted as **outside**
the hull.

Also, the trilist argument is deprecated and raises a warning.

Finally, the point_in_pointcloud can actually take an
arbitrary callable for overriding the test.

@patricksnape patricksnape referenced this pull request Mar 29, 2015

Merged

Zoom #570

@jabooth

This comment has been minimized.

Member

jabooth commented Mar 31, 2015

+1

jabooth added a commit that referenced this pull request Mar 31, 2015

Merge pull request #569 from patricksnape/update_constrain
Add new point_in_pointcloud kwarg to constrain

@jabooth jabooth merged commit f7214f6 into menpo:master Mar 31, 2015

2 of 3 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Mar 31, 2015

@jabooth jabooth deleted the patricksnape:update_constrain branch Mar 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment