New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets for IPython3 #574

Merged
merged 50 commits into from May 28, 2015

Conversation

Projects
None yet
4 participants
@nontas
Member

nontas commented Apr 18, 2015

This PR changes all widgets, so that they:

  • Are compatible with IPython 3.1.0
  • Are defined as classes which makes them much easier to use (and the code is easier to read).

The major changes and improvements are:

  • It is made sure that every widget change (trait value change) triggers only one call of the render function. Until now, this wasn't the case, and sometimes a widget update (e.g. slider move) would call the render function multiple times. Thus, the widgets now are and feel faster.
  • The styling of the widgets has now completely changed. They all have a style argument that can be set to 'coloured' (default) or 'minimal'. The 'coloured' one employs colouring, border lines and a totally different design than before. The 'minimal' theme is the same black and white style as before.
  • All the new widget classes have style() and predefined_style() methods for styling the widget, add_render_function(), remove_render_function() and replace_render_function() for handling the rendering function and a set_widget_state() method for updating the state of the widget.
  • All the basic widget components in menpo.visualize.widgets.options are now added to the docs.

Note that this PR should be merged along with menpo/menpofit#31.

nontas added some commits Mar 12, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented May 18, 2015

@nontas sign the contributors license agreement!

nontas and others added some commits May 18, 2015

Merge remote-tracking branch 'upstream/master' into widgets_format_ip…
…ython3

Conflicts:
	docs/source/api/menpo/visualize/index.rst
	menpo/visualize/__init__.py
	menpo/visualize/widgets/base.py

@nontas nontas referenced this pull request May 27, 2015

Merged

Widgets for IPython3 #31

nontas added some commits May 27, 2015

@jabooth

This comment has been minimized.

Member

jabooth commented May 28, 2015

@nontas looks good! few things:

Our builds are currently failing due to the new logo folder you have added to the menpo/data directory. I'm not sure if there are going to be other ramifications from this in terms of things like menpo.io.import_builtin_assets. We can sort this easily though.

You have the few checkboxes still to complete about notebooks - we can merge this in sooner and make a new issue on the menpo-notebooks repo to track that getting done.

Would be great to get all this brought in this week if we can!

@jalabort

This comment has been minimized.

Member

jalabort commented May 28, 2015

I'm with James, better to split this up, get it in, start using it and report possible bugs.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented May 28, 2015

😮 Everything works! Lets get this in! +1

nontas added a commit that referenced this pull request May 28, 2015

@nontas nontas merged commit 75b0586 into menpo:master May 28, 2015

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label May 28, 2015

@nontas nontas deleted the nontas:widgets_format_ipython3 branch May 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment