New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the landmark importer in case the landmark file has a '.' in its filename. #581

Merged
merged 2 commits into from May 21, 2015

Conversation

Projects
None yet
3 participants
@grigorisg9gr
Member

grigorisg9gr commented May 20, 2015

The extension in this case is the last one of the .suffixes. Similar to #543 that was the respective one for images.

Fix the landmark importer in case the landmark file has a '.' in its …
…name. Then the extension is the last one of the .suffixes.

@jabooth jabooth added the in progress label May 20, 2015

@@ -604,6 +604,9 @@ def glob_with_suffix(pattern, extensions_map):
# .suffix only takes
if ''.join(path.suffixes) in extensions_map:
yield path
# try again in case the filename has a '.' in it, this time only with the suffix
if path.suffix in extensions_map:

This comment has been minimized.

@patricksnape

patricksnape May 20, 2015

Contributor

Python 3 says that this is mixed tabs and spaces! Thank god for automated builds.

jabooth added a commit that referenced this pull request May 21, 2015

Merge pull request #581 from grigorisg9gr/ln_importer_suffix
Fix the landmark importer in case the landmark file has a '.' in its filename.

@jabooth jabooth merged commit bbf95a6 into menpo:master May 21, 2015

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label May 21, 2015

@grigorisg9gr grigorisg9gr deleted the grigorisg9gr:ln_importer_suffix branch May 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment