New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix as_matrix where the iterator finished early #586

Merged
merged 3 commits into from Jun 1, 2015

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented May 21, 2015

as_matrix() presently did not report an error if an iterator terminated early. Fixed, and added test.

@jabooth jabooth added the in progress label May 21, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented May 22, 2015

looks nice, but I haven't tested it yet

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jun 1, 2015

+1

patricksnape added a commit that referenced this pull request Jun 1, 2015

Merge pull request #586 from jabooth/as_matrix_fix
fix as_matrix where the iterator finished early

@patricksnape patricksnape merged commit 658ccad into menpo:master Jun 1, 2015

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patricksnape patricksnape deleted the jabooth:as_matrix_fix branch Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment