New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale around centre #591

Merged
merged 3 commits into from Jun 25, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Jun 1, 2015

This relies on #590.

Small amount of refactoring, but it mostly adds two new utility
methods, scale_about_centre and rotate_about_centre. These
perform the common operation of translating an object to the
origin, rotate/scale and then translate back. It also updates
a number of methods to use these functions since we actually
already performed this in 2/3 places such as procrustes.

New utility methods - scale/rotate about centre
This relies on #590.

Small amount of refactoring, but it mostly adds two new utility
methods, scale_about_centre and rotate_about_centre. These
perform the common operation of translating an object to the
origin, rotate/scale and then translate back. It also updates
a number of methods to use these functions since we actually
already performed this in 2/3 places such as Procrustes.

patricksnape added some commits Jun 22, 2015

Fix errors from merge
Missing MenpoDeprecationWarning import
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jun 25, 2015

@jabooth can we merge this?

@jabooth

This comment has been minimized.

Member

jabooth commented Jun 25, 2015

+1

jabooth added a commit that referenced this pull request Jun 25, 2015

@jabooth jabooth merged commit c576197 into menpo:master Jun 25, 2015

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Jun 25, 2015

@jabooth jabooth deleted the patricksnape:scale_around_centre branch Jun 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment