New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for new cyvlfeat #603

Merged
merged 1 commit into from Jul 5, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Jul 3, 2015

This should fix menpo for the newly updated cyvlfeat - which
should now be consistently Y, X instead of X, Y and also
returns the arrays (n_samples, n_features) which makes
them C-contiguous. The only thing is that it seems equivalent
to the transpose in Matlab, which may be a mistake or may
be by design... who knows.

Also, since I messed up the versioning, the master builds are picking up the new cyvlfeat, and this should stop PRs from failing...

Fixes for new cyvlfeat
This should fix menpo for the newly updated cyvlfeat - which
should now be consistently Y, X instead of X, Y and also
returns the arrays (n_samples, n_features) which makes
them C-contiguous. The only thing is that it seems equivalent
to the transpose in Matlab, which may be a mistake or may
be by design... who knows.
@jabooth

This comment has been minimized.

Member

jabooth commented Jul 5, 2015

Now we have an OS X master build everything is passing. I'll get this straight in as it's causing failures on all menpo PR builds. +1

jabooth added a commit that referenced this pull request Jul 5, 2015

@jabooth jabooth merged commit b51f024 into menpo:master Jul 5, 2015

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth deleted the patricksnape:cyvlfeat_fixes branch Jul 5, 2015

@jabooth jabooth removed the in progress label Jul 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment