New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that LJSON landmarks are read in as floats #619

merged 1 commit into from Aug 3, 2015


None yet
2 participants

jabooth commented Aug 3, 2015

Currently if LJSON file landmarks contain no decimal period (e.g. 403, not 403.23) then the numpy dtype ends up being upon parsing. This was causing a problem in the menpobench matlab bridge - maybe we're better just enforcing float all the time to avoid any small issues like this.

@jabooth jabooth added the in progress label Aug 3, 2015


This comment has been minimized.


patricksnape commented Aug 3, 2015

OK with me +1

jabooth added a commit that referenced this pull request Aug 3, 2015

Merge pull request #619 from jabooth/lm_float
Ensure that LJSON landmarks are read in as floats

@jabooth jabooth merged commit 40af993 into menpo:master Aug 3, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
clahub All contributors have signed the Contributor License Agreement.
continuous-integration/appveyor AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@jabooth jabooth removed the in progress label Aug 3, 2015

@jabooth jabooth deleted the jabooth:lm_float branch Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment