New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define patches offsets as ndarray #620

merged 1 commit into from Aug 18, 2015


None yet
3 participants

nontas commented Aug 4, 2015

Till now, the sample_offsets argument of extract_patches() in Image class was expected to be a PointCloud. However, this doesn't make much sense. The sampling offsets are not a set of points. They should be a set of offsets to be applied to all landmarks. This PR makes this change and requires the sample_offsets is actually a numpy.array of size (n_offsets, n_dims).

@jabooth jabooth added the in progress label Aug 4, 2015


This comment has been minimized.


patricksnape commented Aug 4, 2015

Fine. But this is a breaking change so next release of Menpo will have to be 0.6.x unless we branch and re-merge a hotfix. Just a note.


This comment has been minimized.


patricksnape commented Aug 11, 2015

@jabooth - shall we get this in and and then do the whole tag thing?


This comment has been minimized.


patricksnape commented Aug 18, 2015

I'm pulling this in for @nontas

patricksnape added a commit that referenced this pull request Aug 18, 2015

Merge pull request #620 from nontas/extract_patches_offsets
Define patches offsets as ndarray

@patricksnape patricksnape merged commit 8e06c20 into menpo:master Aug 18, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
clahub All contributors have signed the Contributor License Agreement.
continuous-integration/appveyor AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@nontas nontas deleted the nontas:extract_patches_offsets branch Sep 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment