New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets Migration #632

Merged
merged 12 commits into from Sep 10, 2015

Conversation

Projects
None yet
3 participants
@nontas
Member

nontas commented Sep 4, 2015

This PR removes all widgets, since they now live in menpowidgets package (https://github.com/menpo/menpowidgets). This includes the following:

  • menpo.visualize.widgets is completely removed.
  • All view_widget() methods attempt to import the respective widget from menpowidgets and if they fail, a newly defined MenpowidgetsError() is raised.
  • Dependencies are fixed (ipython and jupyter are removed from conda/meta.yaml).

Please check it (especially the dependencies that I changed) to make sure that there is no major error.

@jabooth jabooth added the in progress label Sep 4, 2015

@nontas nontas referenced this pull request Sep 4, 2015

Merged

Widgets Migration #75

@@ -23,8 +23,6 @@ requirements:
# Convenience dependencies (not strictly required)
- mock 1.0.1
- nose
- ipython 4.*

This comment has been minimized.

@patricksnape

patricksnape Sep 9, 2015

Contributor

We need a dependency on menpowidgets - in the setup.py as well

patricksnape added some commits Sep 9, 2015

Add new MenpoMissingDependancyError
This is now used for menpo3d and menpowidgets. It is also
used for cyvlfeat. It abstract out the error message will tells
people to install the package.
Update dependencies, but not menpowidgets yet
Move to the latest version of all packages since all tests still
pass.
Incorrect abuse of ImportError - use ValueError instead
In a rarely used landmarking importer.
Mock import errors
Adds a new surrogate method which mocks missing modules - adds
tests for missing modules and fixes bugs which were found
from writing the tests!
Fix error message printing
Need to override __str__ for exceptions.
Hide vlfeat properly.
Add an optional sub-package in features that can hide optional
dependencies like vlfeat.
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Sep 9, 2015

I think this is done now - but because menpowidgets and menpo have a circular dependancy on each other, we can never get the automated builds to kick off without commenting out the menpowidgets dependency for now. So I will merge this, which will create a valid build, then menpowidgets will build, then I can push a HOTFIX that uncomments the requirement.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Sep 10, 2015

OK - merging this so that menpowidgets will build

patricksnape added a commit that referenced this pull request Sep 10, 2015

@patricksnape patricksnape merged commit 2a94e4c into menpo:master Sep 10, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nontas nontas deleted the nontas:widgets_migrate branch Sep 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment