New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing @patricksnape and @nontas foolish errors #634

merged 2 commits into from Sep 22, 2015


None yet
4 participants

yuxiang-zhou commented Sep 21, 2015

@patricksnape is writing this. Fixes a bad merge from @nontas and I.

Yuxiang Zhou added some commits Sep 21, 2015

Yuxiang Zhou
@patricksnape=fool. Incorrect mirroring logic
The flipping of the rotation sign should only be done if
the determinant is < 0. Otherwise, there is no flipping!
Yuxiang Zhou
@nontas=fool. Implicit parameter passing is bad.
Have to explicitly label the kwarg otherwise python 2 implicitly
passes the parameter through.

@jabooth jabooth added the in progress label Sep 21, 2015


This comment has been minimized.

menpobot commented Sep 21, 2015

Can one of the admins verify this patch?


This comment has been minimized.


patricksnape commented Sep 22, 2015

add to whitelist

patricksnape added a commit that referenced this pull request Sep 22, 2015

@patricksnape patricksnape merged commit eb96f89 into menpo:master Sep 22, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
clahub All contributors have signed the Contributor License Agreement.
continuous-integration/appveyor AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment