New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add from_tri_mask method to TriMesh instances #639

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Oct 12, 2015

our from_mask machinery on PointCloud instances always masks based on .points. On TriMesh instances, it can be useful to mask based on triangles instead. This adds a new TriMesh.from_tri_mask() method that prepares a point mask from a triangle mask and then delgates to the from_mask() method.

@jabooth jabooth added the in progress label Oct 12, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Oct 13, 2015

+1 looks good - although it is missing a test...

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Nov 23, 2015

Happy for this to go in whenever it gets a test.

jabooth and others added some commits Oct 12, 2015

@patricksnape patricksnape force-pushed the jabooth:tri_mask branch from 40ff815 to a2c511e Mar 8, 2016

patricksnape added a commit that referenced this pull request Mar 8, 2016

Merge pull request #639 from jabooth/tri_mask
add from_tri_mask method to TriMesh instances

@patricksnape patricksnape merged commit 042b3b1 into menpo:master Mar 8, 2016

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patricksnape patricksnape deleted the jabooth:tri_mask branch Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment