New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn coverage checking back on #648

Merged
merged 1 commit into from Feb 11, 2016

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Nov 24, 2015

This should only upload coverage for travis - which is all
we want really.

Re-enable coverage on Travis
Little bit hacky, have to copy the .coverage file across
to the GIT repository for coveralls to work, but it seems
to work for now.

@patricksnape patricksnape force-pushed the patricksnape:coverage branch from 991671b to 9e584ee Feb 10, 2016

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 10, 2016

jenkins retest this please

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 10, 2016

@jabooth this works - can I merge?

@jabooth

This comment has been minimized.

Member

jabooth commented Feb 10, 2016

@patricksnape can we test that test failures still correctly fail CI checks with this change? Just that I seem to remember we moved to run_test.py as we were experiencing a nasty bug with silent failures (although my memory is hazy).

@jabooth

This comment has been minimized.

Member

jabooth commented Feb 10, 2016

4f3c394 was the hotfix in question, I misremembered, was an issue within run_test.py. @patricksnape if you are confident that tests will still fail, +1.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 10, 2016

You want me to add a failing test, then remove it to show that?

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 11, 2016

@jabooth Happy with those failures?

@patricksnape patricksnape force-pushed the patricksnape:coverage branch from 36ea73c to 9e584ee Feb 11, 2016

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 11, 2016

You saw it! Force pushed away!

@jabooth

This comment has been minimized.

Member

jabooth commented Feb 11, 2016

You failed beautifully 👍
(record https://travis-ci.org/menpo/menpo/builds/108552108)
+1

patricksnape added a commit that referenced this pull request Feb 11, 2016

Merge pull request #648 from patricksnape/coverage
Try turning coverage checking back on

@patricksnape patricksnape merged commit 0953ad6 into menpo:master Feb 11, 2016

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patricksnape patricksnape changed the title from Try turning coverage checking back on to Turn coverage checking back on Feb 11, 2016

@patricksnape patricksnape deleted the patricksnape:coverage branch Feb 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment