New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix and improvements in visualize package #655

Merged
merged 10 commits into from Dec 9, 2015

Conversation

Projects
None yet
3 participants
@nontas
Member

nontas commented Nov 29, 2015

This PR fixes the following bugs:

  • Corrects the viewing behaviour of PointCloud and PointGraph objects in case image_view=True, i.e. the way that the y axis gets inverted.
  • Prints the LandmarkGroup name in the legend (before, it was only printing 'group').

It also adds the following:

  • Adds axes_x_ticks and axes_y_ticks to all view() methods. This is especially useful when plotting curves (e.g. CED).
  • Adds a new plot_curve() method in menpo.visualize that can plot multiple curves.
  • Changes the axes_x_limits and axes_y_limits behaviour. Specifically, if float, then it sets padding around the object that is visualized defined as a percentage of the object's width. If tuple or list, then they define the axes limits. If None, then the limits are set automatically.
  • Adds the ability to print numbers on the points of a PointCloud or a PointGraph.

Finally, note that this PR also changes the matplotlib dependency to:

matplotlib>=1.5,<1.6

which removes an annoying warning that they used to print.

@jabooth jabooth added the in progress label Nov 29, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Nov 30, 2015

Right, lots of changes here - will check this out later tonight.

setup.py Outdated
@@ -28,7 +28,7 @@
include_dirs = [np.get_include()]
install_requires = ['numpy>=1.10,<1.11',
'scipy>=0.16,<0.17',
'matplotlib>=1.4,<1.5',
'matplotlib>=1.5,<1.6',

This comment has been minimized.

@jabooth

jabooth Dec 7, 2015

Member

we need this in conda/meta.yaml too

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Dec 9, 2015

Right well this passed so I'm going to +1 this @jabooth for the 0.6.1 release

@jabooth

This comment has been minimized.

Member

jabooth commented Dec 9, 2015

Sounds good, thanks @nontas and @patricksnape +1

jabooth added a commit that referenced this pull request Dec 9, 2015

Merge pull request #655 from nontas/view_shapes_bug
Bugfix and improvements in visualize package

@jabooth jabooth merged commit 46854d2 into menpo:master Dec 9, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Dec 9, 2015

@jabooth jabooth deleted the nontas:view_shapes_bug branch Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment