New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup as_greyscale #668

Merged
merged 3 commits into from Feb 5, 2016

Conversation

Projects
None yet
1 participant
@patricksnape
Contributor

patricksnape commented Feb 3, 2016

Use a dot product for as_greyscale. Also - as_greyscale now respects the original image type which allows creating greyscale images from uint8.

patricksnape added some commits Feb 3, 2016

Improve as_greyscale method - use dot product
as_greyscale is now about 30% using a dot product (the reshapes
are free due to memory alignment). Also, as_greyscale
now respects the data type of the input array - meaning that
you can as_greyscale uint8 images!
Update image tests
Use init_blank and copy=False - also added uint8 as_greyscale
test
Fix small bug in dsift_vector
Newer numpy does not like augmented assignments across
varying types.

patricksnape added a commit that referenced this pull request Feb 5, 2016

@patricksnape patricksnape merged commit fc915c6 into menpo:master Feb 5, 2016

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patricksnape patricksnape deleted the patricksnape:greyscale branch Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment