New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conda environment.yml on RTD #672

Merged
merged 11 commits into from Feb 17, 2016

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Feb 9, 2016

This makes the setup.py much simpler and also means that we don't have to maintain a horrible list of Mocks in the docs conf.py which was error prone and frustrating.

The downside is that the docs/rtd_environment.yml must be kept in sync with the meta.yaml. The environment yaml seems to be more sensitive to the = sign between requirements so we may want to try updating our meta.yaml so that you can just copy and paste to maintain it.

patricksnape added some commits Feb 9, 2016

Try using the new conda environment for RTD
This involes adding the rtd_environment.yml and changing
the setup.py so that we always build the cython extensions.
I like this because it makes the setup.py simpler!
Don't list the requirements if you aren't using it
A bit confusing since we now have options in the RTD website
and this YML but it seems to prefer the YML
Environment YML has different spec to build
Requires the = explicitly
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 10, 2016

Update this when the imageio branch comes in to reflect the new requirements.

@jabooth

This comment has been minimized.

Member

jabooth commented Feb 10, 2016

@patricksnape I've updated Deploying a new release to explain we should update deps in rtd_enviornment.yml.

+1

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Feb 17, 2016

This works with the latest master - pulling it in.

patricksnape added a commit that referenced this pull request Feb 17, 2016

Merge pull request #672 from menpo/conda_yml_rtd
Use Conda environment.yml on RTD

@patricksnape patricksnape merged commit b0d0dcb into master Feb 17, 2016

2 of 6 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@patricksnape patricksnape deleted the conda_yml_rtd branch Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment