New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the view_patches to show only the selected landmarks. #682

Merged
merged 2 commits into from Mar 10, 2016

Conversation

Projects
None yet
3 participants
@grigorisg9gr
Member

grigorisg9gr commented Mar 10, 2016

Previously, even if you selected some indices, all the landmarks were rendered.

@jabooth jabooth added the in progress label Mar 10, 2016

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Mar 10, 2016

The Appveyor error is just a stupid broken pipe on uploading - everything is fine. This looks like a good fix - thanks @grigorisg9gr.

One thing @grigorisg9gr - maybe add yourself to the bottom of the AUTHORS list if you like? You can just add it to the bottom of this PR 😄

@grigorisg9gr

This comment has been minimized.

Member

grigorisg9gr commented Mar 10, 2016

OK, thanks. Done

patricksnape added a commit that referenced this pull request Mar 10, 2016

Merge pull request #682 from grigorisg9gr/minor_change_view_patches
Update the view_patches to show only the selected landmarks.

@patricksnape patricksnape merged commit 8b2ee6e into menpo:master Mar 10, 2016

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Mar 10, 2016

Great!

@patricksnape patricksnape deleted the grigorisg9gr:minor_change_view_patches branch Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment