New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video importing warnings #698

Merged
merged 6 commits into from May 20, 2016

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented May 19, 2016

Imageio incorrectly calculates the number of frames in a video as
int(round(duration * fps)) which is actually just a close approximation
to the total number of frames. Videos don't actually contain individual
frames and, depending on the algorithm, are usually roughly composed of
key frames + interpolation. Therefore, videos should really be accessed
via time stamps. Therefore, we try and just improve the experience by
removing frames whereby ffmpeg throws an error.

patricksnape added some commits May 19, 2016

Fix documentation errors - add missing docs
Missing docs for import_video, import_videos, video_paths, pickle_paths.
Also, fix Python 3 error for importing custom sphinx extensions.
Deal with imageio video errors
Imageio incorrectly calculates the number of frames in a video as
int(round(duration * fps)) which is actually just a close approximation
to the total number of frames. Videos don't actually contain individual
frames and, depending on the algorithm, are usually roughly composed of
key frames + interpolation. Therefore, videos should really be accessed
via time stamps. Therefore, we try and just improve the experience by
removing frames whereby ffmpeg throws an error.
Ignore _build in source folder
Try to guess where read the docs is creating a dirty git
status from.
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented May 19, 2016

Appveyor is lying - it passes. @jabooth please merge when you are happy with it.

patricksnape and others added some commits May 19, 2016

@jabooth

This comment has been minimized.

Member

jabooth commented May 20, 2016

+1, LTFM and get this release out the door!

@jabooth jabooth merged commit a5617b5 into menpo:master May 20, 2016

4 checks passed

OS X MenpoBot Jenkins build passed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label May 20, 2016

@patricksnape patricksnape deleted the patricksnape:video_warnings branch May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment