New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyList init methods and are now Copyable #707

Merged
merged 8 commits into from Jun 10, 2016

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Jun 9, 2016

Just a couple of small improvements:

  • LazyList is now copyable - helps propagate duck typed elements such as path
  • init_from_iterable for creating LazyLists from existing iterables
  • map now allows a list of callables
  • repeat for lazily expanding a LazyList to copy the elements - useful for SDM training
  • Fix lazy landmark importing to propagate path and fps properly now that map uses copying.

patricksnape added some commits Jun 7, 2016

Allow map to receive multiple functiosn
Allows mapping a list of functions to a list, must have the same
length
Add repeat method (handy for SDM training)
Allow repeating items multiple times in a lazylist
Add init_from_iterable
Very handy method to enable creating a lazy list from an existing
list/iterable. Also allows mapping some function to that list.
Make LazyList Copyable
Basically just make sure the underlying _callables list
is a new list so that any appending would not affect
copies.
Use copyable interface
This should help ensure things ducktyped to LazyLists are
propagated such as paths etc.
Update lazy landmark importing to use map
Now fps and path are propagated properly
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jun 9, 2016

@jabooth please review!

@jabooth

This comment has been minimized.

Member

jabooth commented Jun 10, 2016

@patricksnape great, really nice advancement of the LazyList paradigm. +1.

@jabooth jabooth merged commit a861da7 into menpo:master Jun 10, 2016

3 checks passed

OS X MenpoBot Jenkins build passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Jun 10, 2016

@patricksnape patricksnape deleted the patricksnape:lazylist_improve branch Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment