New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise the kwargs in exporting video with ffmpeg. #714

Merged
merged 2 commits into from Aug 4, 2016

Conversation

Projects
None yet
3 participants
@grigorisg9gr
Member

grigorisg9gr commented Jul 1, 2016

Previously the kwargs were not used in ffmpeg_video_exporter(), thus several options (e.g. compression) could not be changed.

@jabooth jabooth added the in progress label Jul 1, 2016

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 5, 2016

Looks good, just re-running weird crash on MenpoBot.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 7, 2016

Alright, sorry about this, jenkins is being really strange

@patricksnape patricksnape force-pushed the grigorisg9gr:kwargs_export_video branch from 2fa057a to d9492bb Aug 1, 2016

@patricksnape patricksnape reopened this Aug 4, 2016

@patricksnape patricksnape added in progress and removed in progress labels Aug 4, 2016

@patricksnape patricksnape merged commit 68a7cbb into menpo:master Aug 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS MenpoBot Jenkins build passed
Details

@patricksnape patricksnape deleted the grigorisg9gr:kwargs_export_video branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment