New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for unpickling of the older PCAModel #728

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Aug 12, 2016

Simple fix just by using __setstate__ to detect whether
the old mean_vector is there or not.

This also fixes a bug in init_from_components for PCAVectorModel.

This addresses #725.

Allow for unpickling of the older PCAModel
Simple fix just by using __setstate__ to detect whether
the old mean_vector is there or not.
@jabooth

This comment has been minimized.

Member

jabooth commented Aug 15, 2016

@patricksnape, yup looks great. Nice future template for handling these issues too.

Wonder if we should throw a depreciation warning here, or do we intend to keep this around indefinitely?

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Aug 15, 2016

I'm easy - happy to raise a warning if you like - we do that for LJSON for example.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Aug 15, 2016

We will raise a warning later.

@patricksnape patricksnape merged commit 0537d48 into menpo:master Aug 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS MenpoBot Jenkins build passed
Details

@patricksnape patricksnape deleted the patricksnape:pca_pickle branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment