New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation change in image gradient for int pixels dtype. #745

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
2 participants
@grigorisg9gr
Member

grigorisg9gr commented Sep 23, 2016

Small clarification, because the gradient crashes if dtype is int/uint in the cython file.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Sep 27, 2016

This is true. Primarily because integer gradients don't make a lot of sense. However, we could always cast the input data if people think that would be useful. Though we'd have to chose some rounding scheme to ensure you get integers back.

@patricksnape patricksnape merged commit 1dfe7c7 into menpo:master Sep 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS MenpoBot Jenkins build passed
Details

@patricksnape patricksnape deleted the grigorisg9gr:gradient_doc branch Sep 27, 2016

@grigorisg9gr

This comment has been minimized.

Member

grigorisg9gr commented Sep 27, 2016

Or as a future workaround instead of modifying the cython/c++ files, it could also go in the _np_gradient() part that calls the numpy diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment