New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithDims transform and with_dims method #751

merged 3 commits into from Nov 25, 2016


None yet
2 participants

jabooth commented Nov 17, 2016

Adds a new WithDims transform for doing dimensionality slicing, and a convenience method to use it on PointCloud and subclasses (PointCloud.with_dims(self, dims))

from menpo.transform import WithDims

def test_withdims_transform():

This comment has been minimized.


patricksnape Nov 18, 2016


Add a test for when you slice with a single element (which you can do - a single integer is a valid use of this function) e.g. pc.with_dims(0) returns a 1D point cloud of the first dimension.

This comment has been minimized.


jabooth Nov 23, 2016


Nice catch. Added support for this and a test.

@patricksnape patricksnape merged commit ba22990 into menpo:master Nov 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
macOS MenpoBot Jenkins build passed

@patricksnape patricksnape deleted the jabooth:with_dims branch Nov 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment