New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linksearch cannot handle protocol-relative URLs #16

Closed
GoogleCodeExporter opened this Issue Mar 21, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Mar 21, 2015

Example: 
https://wikipediatools.appspot.com/linksearch.jsp?link=translatewiki.net

There should be a few hundreds links, it shouldn't timeout; and even in that 
case a partial output could be provided. Perhaps still needs to use APIs?

Original issue reported on code.google.com by nemow...@gmail.com on 6 Sep 2012 at 9:32

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Mar 21, 2015

This one isn't a timeout. Stack trace from server logs:

java.net.MalformedURLException: no protocol: 
//translatewiki.net/wiki/Special:AdvancedTranslate?module=words
    at java.net.URL.<init>(URL.java:583)
    at java.net.URL.<init>(URL.java:480)
    at java.net.URL.<init>(URL.java:429)
    at org.wikipedia.Wiki.linksearch(Wiki.java:4160)
    at org.wikipedia.servlets.XWikiLinksearch.linksearch(XWikiLinksearch.java:106)
    at org.wikipedia.servlets.XWikiLinksearch.doGet(XWikiLinksearch.java:86)
    ...

This isn't really my fault. I should really catch exceptions instead of using a 
static handler. 

Original comment by stop.squark on 6 Sep 2012 at 11:33

  • Changed title: Linksearch cannot handle protocol-relative URLs
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Mar 21, 2015

Thank you for investigating. This is a bug in java.net, you mean? Is it filed?
Perhaps API should also provide a way to work around this, I filed 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40052 to find out.

Original comment by nemow...@gmail.com on 6 Sep 2012 at 12:39

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Mar 21, 2015

Google App Engine uses a legacy (and stale, because Oracle sucks) version of 
Java. I can work around this problem easily.

Original comment by stop.squark on 7 Sep 2012 at 7:24

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Mar 21, 2015

>I should really catch exceptions instead of using a static handler. 
Done in r90.
>I can work around this problem easily.
Done in r91.

Original comment by stop.squark on 21 Sep 2012 at 12:59

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment