Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhd] Relax requirement on droid-config-flashing #208

Closed
wants to merge 1 commit into from
Closed

[dhd] Relax requirement on droid-config-flashing #208

wants to merge 1 commit into from

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Feb 28, 2019

Trust droid-config-%{rpm_device}-flashing to provide droid-config-flashing.
Eases handling of product families like Sony's lineup.

Trust droid-config-%{rpm_device}-flashing to
provide droid-config-flashing. Eases handling of
product families like Sony's lineup.
@sledges
Copy link
Contributor

sledges commented Mar 15, 2019

Sadly this would break our OBS builds where we build for more than one Sony model and variant (currently we build for 6 of them) and OBS would not know which droid-config-flashing to choose, as there would be 6 to choose from. This could we worked around via OBS's project-config (prjconf), but it'd then be one more place to remember when we add a new device.
What is your use case, and is there a possible compromise?

@ix5
Copy link
Contributor Author

ix5 commented Mar 15, 2019

d-h-d wants droid-config-%{rpm_device}-flashing, where rpm_device will be the model codename(discovery/kagura), not model number(h4331/f8331).
So d-h-d wants droid-config-kagura-flashing.

d-h-c provides droid-config-%{rpm_device}-flashing, where rpm_device is the model number this time, e.g. droid-config-f8331-flashing. So there's a mismatch.

Because you are setting have_custom_img_boot and thus skipping over this section and using droid-hal-img-boot-*(which only wants the generic droid-config-flashing) you don't see the issue I guess.

@ix5
Copy link
Contributor Author

ix5 commented Mar 15, 2019

I realize I'm an edge-case building a product-family device without droid-hal-img-boot-$DEVICE.

@ix5
Copy link
Contributor Author

ix5 commented Mar 15, 2019

It's all a bit weird, because in other places, you have this:
rpm_device: f8331
device: kagura

But in d-h-d you have:
rpm_device: kagura (because rpm_device = device if rpm_device is empty)
device: kagura

@ix5
Copy link
Contributor Author

ix5 commented Jun 3, 2020

Pfff

@ix5 ix5 closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants