dhd: Omit droidmedia+audioflingerglue from libexec #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove droidmedia and audioflingerglue libs+bins from
$RPM_BUILD_ROOT/%{_libexecdir} when building droid-hal-device, thus
preventing clashing files with the localbuild variants.
This commit simply moves the logic around so that one can build all
HABUILD_SDK tasks at once and then not have to worry about the order of
execution for building droid-hal and
droidmedia/audioflingerglue-localbuild.
Without this commit, one has to re-build the droidmedia/audioflingerglue
libs in the HABUILD_SDK every time before packaging the localbuild
variants.
sledges
changed the title
sledges
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
droidmediaandaudioflingergluelibs+bins from$RPM_BUILD_ROOT/%{_libexecdir}when buildingdroid-hal-device, thus preventing clashing files with thelocalbuildvariants.This commit simply moves the logic around so that one can build all
HABUILD_SDKtasks at once and then not have to worry about the order of execution for buildingdroid-halanddroidmedia/audioflingerglue-localbuild.Without this commit, one has to re-build the
droidmedia/audioflingergluelibs in theHABUILD_SDKevery time before packaging thelocalbuildvariants.