hal: Handle not being able to set the SUPL server. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Otherwise looks good but in other places the code uses "if (m_agps)" style so maybe you could follow that style and return 0 at the end after having the current code inside "if (m_agps)"? |
mer-hybris@e982cf9 added support for overriding/setting the SUPL server. This could however lead to a crash when AGPS isn't actually available. Handle this by returning an error instead of crashing. Signed-off-by: Darrel Griët <dgriet@gmail.com>
MagneFire
force-pushed
the
bug/agps-supl
branch
from
c36805b
to
d9d99be
Compare
|
Thanks for the quick review! Great finding on the consistency of the code styling. I've adjusted it to be conform with the style of the other functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e982cf9 added support for overriding/setting the SUPL server. This could however lead to a crash when AGPS isn't actually available. Handle this by returning an error instead of crashing.
Signed-off-by: Darrel Griët dgriet@gmail.com