Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer overflow in print_basic_hash() #116

Closed
jwilk opened this issue Jul 17, 2017 · 1 comment
Closed

Buffer overflow in print_basic_hash() #116

jwilk opened this issue Jul 17, 2017 · 1 comment
Assignees
Milestone

Comments

@jwilk
Copy link
Contributor

@jwilk jwilk commented Jul 17, 2017

print_basic_hash() declares the output buffer as:

char hash_value[EVP_MAX_MD_SIZE * 2 + 1];

With the current OpenSSL versions, EVP_MAX_MD_SIZE * 2 + 1 is 129.
However, fuzzy_hash_buf() requires an output buffer of size FUZZY_MAX_RESULT, which is 148.

jweyrich added a commit to jweyrich/pev that referenced this issue Jul 17, 2017
@jweyrich jweyrich closed this Jul 17, 2017
@jweyrich jweyrich added this to the v0.81 milestone Jul 17, 2017
@jweyrich
Copy link
Collaborator

@jweyrich jweyrich commented Jul 18, 2017

Hopefully my commit did fix it. Thanks for reporting it!

@jweyrich jweyrich self-assigned this Jul 18, 2017
@jweyrich jweyrich added the v0.81 label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.