New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anvi-compute-ani and data groups, Related #505 #822

Merged
merged 109 commits into from May 1, 2018

Conversation

Projects
None yet
2 participants
@ozcan
Member

ozcan commented Apr 30, 2018

No description provided.

@meren

This comment has been minimized.

Member

meren commented on ae55539 Apr 23, 2018

Why not our utility functions instead of popen? They take good care of logging :)

This comment has been minimized.

Member

ozcan replied Apr 23, 2018

Ah yes, thank you for the suggestion @meren. I could totally use utils.run_command here, it seems it handles both return codes and logging, very handy in this situation.

@ozcan ozcan requested a review from meren Apr 30, 2018

@meren

meren approved these changes May 1, 2018

This is significant work, @ozcan. Thank you! I went through the code, and fixed minor things.

@meren meren merged commit 0c0a396 into master May 1, 2018

@ozcan ozcan deleted the anvi-compute-ani branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment