Fixing JSON parse error being thrown, returning friendlier error message #2

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jesseditson

A non-JSON response would throw an ugly JSON parse error and stack trace would point inside of the module. (encountered this when getting a 404 from tumblr.)

Added try/catch around the json parsing of the response, and returning "Invalid Response" as the error when non-json response is encountered.

@meritt meritt was assigned Jun 9, 2012
@meritt meritt added a commit that closed this pull request Jan 8, 2013
@meritt Fix #2 issue 62f969f
@meritt meritt closed this in 62f969f Jan 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment