Tim Nagel
merk

Organizations

@FriendsOfSymfony @ozfortress @infinite-networks @discutere
Aug 23, 2016
Aug 23, 2016
@merk
Aug 17, 2016
merk commented on issue simplethings/EntityAudit#203
@merk

@tolry there can be no BC breaks at this point as 1.0 has not been released. Sorry? 0.x series version numbers allow any BC breaks you want. http…

Jun 27, 2016
merk commented on pull request ruflin/Elastica#1124
@merk

Which is already in the changelog: 11bcfe2

Jun 27, 2016
merk commented on pull request ruflin/Elastica#1124
@merk

The heading should be 'Backwards Compatibility Breaks', but this changelog entry should be with the composer.json update to >=5.4 since it is alrea…

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1124
@merk

Given there is a requirement of >=5.4 in composer.json this change isnt necessary to list, imo.

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1125
@merk

Whenever code is touched for changes like this without tests it is worth the effort to validate that there is no functionality changed by adding a …

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1124
Jun 26, 2016
merk commented on pull request ruflin/Elastica#1124
@merk

Using short arrays doesnt deprecate 5.3, nor is it a BC fix, it is a BC break

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1126
@merk

This change needs a unit or functional test, since there is no test coverage of CandidateGenerator with toArray()

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1125
@merk

Should we be doing a strict comparison here?

Jun 26, 2016
merk commented on pull request ruflin/Elastica#1128
@merk

To me this doesn't increase the readability of the code, and to me that is more important than the conciseness.

Jun 21, 2016
Jun 21, 2016
@merk
  • @merk 3e72997
    Handle embeddable path properties
Jun 6, 2016
merk commented on pull request infinite-networks/InfiniteFormBundle#60
@merk

I'd like to see it remain arbitrary, not everyone will want to expose the underlying type FQCNs in their HTML source. On 6 Jun 2016 9:40 am, "Jonat…

Jun 4, 2016
merk commented on pull request ruflin/Elastica#1108
@merk

Could you please undo the whitespace changes made to these files so its simpler to review?

May 31, 2016
@merk

Thanks, any extra information, even a failing test case would help immensely to find the issue.

May 30, 2016
@merk

The stack trace indicates the error is happening in your AppBundle, chuck a breakpoint in CountryService->getCountryId() to see whats going on.

May 30, 2016
merk commented on pull request FriendsOfSymfony/FOSElasticaBundle#1079
@merk

I'm still 👎 on this - what I'm planning for 4.0 will not be compatible with objects for ids and it will be up to the/a serializer to handle it. I a…

May 30, 2016
merk pushed to master at ruflin/Elastica
@merk
May 30, 2016
merk merged pull request ruflin/Elastica#1104
@merk
adapted Type namespace collision fix for Query\Ids, see PR #438
1 commit with 17 additions and 3 deletions
May 30, 2016
merk commented on pull request ruflin/Elastica#1104
@merk

Thanks!

May 29, 2016
May 26, 2016
merk commented on pull request ruflin/Elastica#1093
@merk

I'd like to consider a few more changes that could come with major BC breaks before we tag 4.0. How do you want to handle merging this stuff? Do yo…

May 26, 2016
merk commented on pull request ruflin/Elastica#1097
@merk

Yep, looks good to me

May 25, 2016
merk commented on pull request FriendsOfSymfony/FOSElasticaBundle#1086
@merk

This bundle still supports PHP 5.3 until 4.0, can you please change the short array syntax in the Callback test to standard arrays?

May 25, 2016
merk commented on pull request FriendsOfSymfony/FOSElasticaBundle#1086
@merk

Thanks!

May 24, 2016
merk commented on pull request ruflin/Elastica#1097
@merk

This is incorrect - these values should not have empty string initialisers, the methods should be modified to return true/false based on null instead.

May 23, 2016
merk commented on pull request ruflin/Elastica#1096
@merk

Its not the change thats the problem, its that there is no need to have it commented out with a TODO comment.

May 23, 2016
merk commented on pull request ruflin/Elastica#1096
@merk

Please remove the code rearrangement (exceptions being thrown elsewhere) to a separate PR so it can be discussed independently of the array syntax …