Skip to content
Browse files

Fixing more scopes per review comments.

  • Loading branch information...
1 parent a63ea29 commit 562a71ff74c9ac887e15b64ac21f07b57843a067 @henrik henrik committed Nov 3, 2007
View
8 Commands/Help.tmCommand
@@ -83,10 +83,10 @@ This document in a web window.
These are some ways you can [modify your theme](http://macromates.com/textmate/manual/themes) to change the syntax highlighting.
* Add a style for <code>meta.header.tasks</code> to affect how headers appear. By default, they're <span style="color:#FFF; background-color:#3467D1">white on blue</span>.
-* Add a style for <code>meta.task.completed.tasks</code> to affect how completed tasks appear. By default, they're <span style="font-style:italic; color:#CCC">gray and italic</span>.
-* Add a style for <code>meta.task.pending.tasks</code> to affect how pending tasks appear. By default, they're <span>unstyled</span>.
-* Add a style for <code>meta.task.completed.tasks punctuation.definition.list_item</code> to affect how completed task bullets (checkmarks) appear. By default, they're <span style="font-style:italic; color:#73FF65">green</span>.
-* Add a style for <code>meta.task.pending.tasks punctuation.definition.list_item</code> to affect how pending task bullets (hyphens) appear. By default, they're <span style="color:#F00">red</span>.
+* Add a style for <code>markup.list.completed.tasks</code> to affect how completed tasks appear. By default, they're <span style="font-style:italic; color:#CCC">gray and italic</span>.
+* Add a style for <code>markup.list.pending.tasks</code> to affect how pending tasks appear. By default, they're <span>unstyled</span>.
+* Add a style for <code>markup.list.completed.tasks punctuation.definition.list_item</code> to affect how completed task bullets (checkmarks) appear. By default, they're <span style="font-style:italic; color:#73FF65">green</span>.
+* Add a style for <code>markup.list.pending.tasks punctuation.definition.list_item</code> to affect how pending task bullets (hyphens) appear. By default, they're <span style="color:#F00">red</span>.
## Change list bullets
View
2 Preferences/Style: Completed symbol.tmPreferences
@@ -5,7 +5,7 @@
<key>name</key>
<string>Style: Completed Symbol</string>
<key>scope</key>
- <string>meta.task.completed.tasks punctuation.definition.list_item</string>
+ <string>markup.list.completed.tasks punctuation.definition.list_item</string>
<key>settings</key>
<dict>
<key>foreground</key>
View
4 Preferences/Style: Completed.tmPreferences
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>name</key>
<string>Style: Completed</string>
<key>scope</key>
- <string>meta.task.completed.tasks</string>
+ <string>markup.list.completed.tasks</string>
<key>settings</key>
<dict>
<key>fontStyle</key>
View
2 Preferences/Style: Pending symbol.tmPreferences
@@ -5,7 +5,7 @@
<key>name</key>
<string>Style: Pending Symbol</string>
<key>scope</key>
- <string>meta.task.pending.tasks punctuation.definition.list_item</string>
+ <string>markup.list.pending.tasks punctuation.definition.list_item</string>
<key>settings</key>
<dict>
<key>foreground</key>
View
4 Preferences/Style: Pending.tmPreferences
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>name</key>
<string>Style: Pending</string>
<key>scope</key>
- <string>meta.task.pending.tasks</string>
+ <string>markup.list.pending.tasks</string>
<key>settings</key>
<dict/>
<key>uuid</key>
View
8 Syntaxes/Tasks.tmLanguage
@@ -37,11 +37,11 @@
</dict>
</dict>
<key>contentName</key>
- <string>meta.task-proper.tasks</string>
+ <string>meta.paragraph.list.tasks</string>
<key>end</key>
<string>$\n?</string>
<key>name</key>
- <string>meta.task.completed.tasks</string>
+ <string>markup.list.completed.tasks</string>
<key>patterns</key>
<array>
<dict>
@@ -67,11 +67,11 @@
</dict>
</dict>
<key>contentName</key>
- <string>meta.task-proper.tasks</string>
+ <string>meta.paragraph.list.tasks</string>
<key>end</key>
<string>$\n?</string>
<key>name</key>
- <string>meta.task.pending.tasks</string>
+ <string>markup.list.pending.tasks</string>
<key>patterns</key>
<array>
<dict>
View
4 comments.mdown
@@ -7,8 +7,8 @@ Generally speaking the goal is to be as general with the scopes as you can be at
✓ punctuation.definition.separator should be punctuation.definition.header, the third level here should describe what it is defining.
- Seeing that source already has a rule for meta.toc-list being in the symbol list both of those preferences are superfluous no?
✓ meta.leading-whitespace should use the new punctuation.whitespace.list_item.leading.tasks
-- punctuation.definition.bullet isn't defining the bullet it's defining the start of a task, hense punctuation.definition.list_item Has the benefit of sharing the same scopes as Markdown.
-- Being that this is a basically a list of tasks the scope for the items can share the scope Markdown and such use: markup.list. So perhaps… markup.list.pending|completed.tasks
+ punctuation.definition.bullet isn't defining the bullet it's defining the start of a task, hense punctuation.definition.list_item Has the benefit of sharing the same scopes as Markdown.
+ Being that this is a basically a list of tasks the scope for the items can share the scope Markdown and such use: markup.list. So perhaps… markup.list.pending|completed.tasks
✓ Help command should not have a key equiv as per the [style guide][1]. Needs to have a scope.
[1]: http://macromates.com/wiki/Bundles/StyleGuide

0 comments on commit 562a71f

Please sign in to comment.
Something went wrong with that request. Please try again.