menu fix for base_url #1

Merged
merged 1 commit into from Oct 16, 2011

Conversation

Projects
None yet
3 participants

rephorm commented Oct 16, 2011

As written, adding a base_url breaks the menu system. Here is a patch.

Owner

merlinrebrovic commented Oct 16, 2011

Hi,

Thank you for the fix :) I'm testing it at the moment. Everything I try is working, so I'll merge it in. The only thing I would prefer is that the default base_url is /, not some other path. That way when a beginner types hyde serve everything works out of the box. I'll leave your part of the configuration commented out with an explanation.

@merlinrebrovic merlinrebrovic added a commit that referenced this pull request Oct 16, 2011

@merlinrebrovic merlinrebrovic Merge pull request #1 from rephorm/master
menu fix for base_url
6d01be9

@merlinrebrovic merlinrebrovic merged commit 6d01be9 into merlinrebrovic:master Oct 16, 2011

rephorm commented Oct 17, 2011

Sounds good. I agree that the default base_url should be /, (I just left it in to demonstrate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment