Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Use actual theme name #3054

Merged
merged 1 commit into from May 24, 2022
Merged

[Documentation] Use actual theme name #3054

merged 1 commit into from May 24, 2022

Conversation

sylhare
Copy link
Contributor

@sylhare sylhare commented May 18, 2022

馃搼 Summary

Remove the caps as it only works when all lowercase. (Base won't work, but base will)

馃搹 Design Decisions

Update documentation to reflect what's used. I thought that fixing the documentation was less error prone than changing the code.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it should be! Thanks

@knsv knsv merged commit 79636af into mermaid-js:develop May 24, 2022
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants