Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation between title and accessibility title (sometimes) #3075

Merged
merged 3 commits into from May 24, 2022

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented May 24, 2022

馃搼 Summary

Gantt charts and journey diagrams mixed up accessibility title with the regular title. Not a certainty that they should be the same.

Resolves #3074

馃搹 Design Decisions

Use separate diagram title and accessibility title. The dedicated title for accessibility is used when present if not, the diagram title is used if that one is present.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce to have them consistent and independent.

@ashishjain0512 ashishjain0512 merged commit 1148039 into develop May 24, 2022
14 checks passed
@knsv knsv deleted the 3074_access branch August 23, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lingering issues with accessibility
2 participants