Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle diagram paddings in a consistent way #3118

Merged
merged 1 commit into from Jun 8, 2022
Merged

Handle diagram paddings in a consistent way #3118

merged 1 commit into from Jun 8, 2022

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jun 8, 2022

馃搼 Summary

Broken out the viewbox handling for dagre diagrams in to separate function which handles the paddings for flowcharts and classdiagrams in a consistent way.

Resolves #3116

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@knsv knsv merged commit 5d30d46 into develop Jun 8, 2022
14 checks passed
@flywire
Copy link
Contributor

flywire commented Jun 11, 2022

Will this clip diagrams with negative padding?

Eg clip right of the diagram below from https://stackoverflow.com/q/72545748/4539999:

image

@knsv knsv deleted the 3116_paddings branch August 23, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paddings around classdiagrams are off
2 participants