Using "hasOwnProperty" to check for direct properties "type" and

"namespace" on events before triggering.
mescoda · Jan 31, 2013 · 5935a36 · 5935a36
1 parent bb1d148
commit 5935a36
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/event.js b/src/event.js
@@ -208,8 +208,8 @@ jQuery.event = {
 
 		var i, cur, tmp, bubbleType, ontype, handle, special,
 			eventPath = [ elem || document ],
-			type = event.type || event,
-			namespaces = event.namespace ? event.namespace.split(".") : [];
+			type = core_hasOwn.call(event, 'type') ? event.type : event,
+			namespaces = core_hasOwn.call(event, 'namespace') ? event.namespace.split(".") : [];
 
 		cur = tmp = elem = elem || document;
 

diff --git a/test/unit/event.js b/test/unit/event.js
@@ -2666,3 +2666,17 @@ test( "Check order of focusin/focusout events", 2, function() {
 	input.off();
 });
 
+test("make sure defining 'namespace' on String.prototype does not cause trigger() to error", function() {
+	expect(1);
+	var errored = false;
+	String.prototype.namespace = function() {
+		return "test";
+	};
+	try {
+		jQuery("<p>").trigger('foo.bar');
+	} catch( e ) {
+		errored = true;
+	}
+	equal(errored, false, 'trigger() should not have errored');
+	delete String.prototype.namespace;
+});