Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/single output #974

Merged
merged 66 commits into from May 29, 2019
Merged

Feature/single output #974

merged 66 commits into from May 29, 2019

Conversation

NicolasMahe
Copy link
Member

Accumulator branch for other single-output-X branches.

krhubert and others added 30 commits May 17, 2019 16:43
@krhubert
Change importer outputs to parameter
348e53d
@krhubert
Fix importer tests
699d36b
@krhubert
Fix service test file definitions
414d414
@krhubert
Update inject definition in api
a2de4ed
@krhubert
Remove test about deploy from external url
ff2aaed
@krhubert
Fix grpc service tests
f8fe9b4
@krhubert
Remove unused code
67fbb14
@krhubert
Change service outputs to parameters
3e5b6d4
@antho1404
remove outputs from system services definition
6641431
@antho1404
add new version of mesg-js in order to keep the marketplace working
0bf787f
@NicolasMahe
Merge branch 'dev' into feature/single-output-pt-1
0b54217
@NicolasMahe
Put back tests that were deleted because they use a remote url to dep…
70e82f0 
…loy a service
@krhubert
Merge pull request #965 from mesg-foundation/feature/single-output-pt…
edef6f5 
…-1-2

Simplify output for system services
@krhubert
Merge pull request #967 from mesg-foundation/feature/single-output-pt…
856260b 
…-1-3

Add back removed test from #963
@krhubert
Change service outputs to parameters
95ca78c
@antho1404
Merge pull request #963 from mesg-foundation/feature/single-output-pt-1
957a563 
First step of simplifaction of task output -  update importer package
@antho1404
Merge branch 'feature/single-output' into feature/single-output-pt-2
0302a1b
@krhubert @NicolasMahe
Fill Output stuct with task key and service name
89487d9
@krhubert @NicolasMahe
Fix exection tests
8f2efbe
@krhubert
Merge branch 'feature/single-output-pt-2' of github.com:mesg-foundati…
5ec321f 
…on/engine into feature/single-output-pt-2
@krhubert
Remove output key from api filter
98467cb
@krhubert
Do not use output filter in cli
ad29d5c
@antho1404
Merge pull request #964 from mesg-foundation/feature/single-output-pt-2
76def4c 
2nd step of simplification of task output - change internal structure
@antho1404
Merge pull request #971 from mesg-foundation/feature/single-output-pt-3
cc70e7d 
3rd step of simplifaction of task output - remove output key from api filter
@NicolasMahe
Merge commit 'feature/single-output-pt-3' into feature/single-output
efee50f
@antho1404
Merge pull request #972 from mesg-foundation/feature/single-output-pt-4
cc676f5 
4th step - do not use output filter in cli
@NicolasMahe
Merge commit 'feature/single-output-pt-4' into feature/single-output
9775025
@NicolasMahe @krhubert
Remove output from service package
5a1b0d5
@krhubert
Remove output key from Execution
5f9b211
@krhubert
Pass return output error to api
9a38d6f
NicolasMahe and others added 10 commits May 23, 2019 20:41
@NicolasMahe
Update ethwallet to use new service client
43a6f55
@krhubert
Remove Output struct from protobuf service definition
1bd0181
@NicolasMahe
Merge pull request #981 from mesg-foundation/feature/single-output-pt-12
d2d4389 
12th step - Do not public message on error during process execution
@NicolasMahe
Merge pull request #982 from mesg-foundation/feature/single-output-pt-13
38c0cf8 
13th step - Update client to handle error
@NicolasMahe
Merge branch 'feature/single-output' into feature/single-output-pt-14
7b64407
@NicolasMahe
Merge pull request #984 from mesg-foundation/feature/single-output-pt-14
8b0bfb2 
14th step - Remove Output struct from protobuf service definition
@NicolasMahe
Use mesg-js beta
0fccc52
@krhubert
Change marketplace task func signature
7e8a657
@antho1404
Merge branch 'feature/single-output' into feature/single-output-ethwa…
6a58742 
…llet
@NicolasMahe
Merge pull request #983 from mesg-foundation/feature/single-output-et…
ca2b945 
…hwallet

Update ethwallet to single output
@antho1404
Copy link
Member

antho1404 commented May 28, 2019 •
edited

I have a file missing error when I start the dev-core command

✔ Core stopped
✔ Core started
time="2019-05-28T07:38:32Z" level=fatal msg="file missing"

edit:
this doesn't seem to be related to this PR, also breaking in the dev branch

@antho1404
Copy link
Member

antho1404 commented May 28, 2019 •
edited

We need to deprecate the service database.
We can set a new serviceDBVersion

#989

@antho1404 antho1404 marked this pull request as ready for review May 29, 2019 02:50
antho1404
antho1404 previously approved these changes May 29, 2019
View reviewed changes
@NicolasMahe
Copy link
Member Author

NicolasMahe commented May 29, 2019 •
edited

The marketplace doesn't return error in this current version. This is fixed with #987. Please review and merge

@NicolasMahe NicolasMahe mentioned this pull request May 29, 2019
Merged
@NicolasMahe NicolasMahe merged commit 835dd55 into dev May 29, 2019
@NicolasMahe NicolasMahe deleted the feature/single-output branch May 29, 2019 09:26
@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/simplification-of-the-tasks-output/265/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NicolasMahe @antho1404 @mesg-bot @krhubert @ilgooz