Skip to content

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Jan 23, 2024

See here for a rendered preview.


This change is Reviewable

@jwnimmer-tri
Copy link
Contributor Author

+@SeanCurtis-TRI could I ask for any early feature-review feedback here? I still have some TODOs to fill out, but I should probably check if I'm moving in the right direction.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. I do somewhat bemoan the informality. There's a part of me wondering if some kind of grammar definition wouldn't be helpful. Especially for the complex set_object(). But this is a definite improvement.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor Author

Thanks. I'll ping you again once I have the additional JSON examples filled in. My hope is that will help mitigate the lack of a more structured specification.

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for a full review no.

No particular rush, I just want to have this baseline ready for when I start changing the protocol (by allowing url instead of data for assets).

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for a full review now*.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jwnimmer-tri)


test/texture_text.html line 50 at r3 (raw file):

                        transparent: true,
                        map: "0c8c99a8-bba8-11ee-b7a2-4b79088b524d",
                    }

BTW If you change the default sided-ness to "2", you can read the text on both sides. The test, as is, is sufficient to show that the text textures work. Extending it slightly to make the text visible from both sides may serve further pedagogical value.

Suggestion:

                    {
                        uuid: "6fe7011b-bba7-11ee-b7a2-4b79088b524d",
                        type: "MeshPhongMaterial",
                        transparent: true,
                        map: "0c8c99a8-bba8-11ee-b7a2-4b79088b524d",
                        // Make the text visible front and back (double sided).
                        side: 2,
                    }

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit 08b5709 into meshcat-dev:master Jan 29, 2024
@jwnimmer-tri jwnimmer-tri deleted the readme branch January 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants