feat: use "terraform output" for documentation instead of local_file #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change results in a better git-enabled workflow because we more cleanly separate sources (kit modules, platform modules) from outputs. It also enables building docs in a separate CI build job that e.g. only has access to TF states but does not need to execute a local "foundation deploy" to make sure output_md files exist and are up to date.
this is necessary to make the navigation structure work
we no longer sort kit modules for documentation
longer have output_md_file inputs This reverts commit e24e72f.
felixzieger
approved these changes
Jul 18, 2023
perfect, missed that. Thanks a lot! |
JohannesRudolph
added a commit
that referenced
this pull request
Aug 9, 2023
This was an oversight when implementing #217, not sure how I missed this. collie kit new will now generate the correct kit module scaffolding
JohannesRudolph
added a commit
that referenced
this pull request
Aug 9, 2023
This was an oversight when implementing #217, not sure how I missed this. collie kit new will now generate the correct kit module scaffolding
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
This was an oversight when implementing #217, not sure how I missed this. collie kit new will now generate the correct kit module scaffolding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change results in a better git-enabled workflow because we more cleanly separate sources (kit modules, platform modules) from outputs. It also enables building docs in a separate CI build job that e.g. only has access to TF states but does not need to execute a local "foundation deploy" to make sure output_md files exist and are up to date.