Disable BLE_PIN_CODE for E290 companion USB environment#2565
Merged
Conversation
Remove the hardcoded BLE_PIN_CODE build flag from the Heltec_E290_companion_ble environment. The presence of BLE_PIN_CODE prevents the unit from operating as a USB companion. Commenting it out allows dynamic PIN generation and enables USB companion functionality.
Member
|
Thanks! I'm not sure if the hash acts as a comment in the .ini file, and if it is required to be the semi colon. Would be best to just remove the line entirely from the USB variant :) |
Author
|
you are right, that line does not belong there, so completely removed now side note: I flashed my HT E290 earlier today with the line removed and i'm now able to connect over USB (using as Homeassistant proxy) |
Member
|
Awesome, thanks! Will merge in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the hardcoded
BLE_PIN_CODEbuild flag from the Heltec_E290_companion_usb environment. The presence ofBLE_PIN_CODEprevents the unit from operating as a USB companion. Commenting it out enables USB companion functionality.Changes
-D BLE_PIN_CODE=123456invariants/heltec_e290/platformio.iniImpact
This allows the E290 unit to function properly as a USB companion device by removing the hardcoded PIN restriction.