[CI] e2e-test adaptersv2 always failed on runresources step

[Aisuko]

Current Behavior

https://github.com/meshery/meshery-istio/actions/workflows/e2etests.yml

Here is the code https://github.com/meshery/meshery/blob/adf27cfc8f1a9c6d02e1cc0351c66757a8bcab3c/.github/workflows/test_adaptersv2.yaml#L262-L272

There is lots of the Shell script to check the resources are already exist or not. And update the existatus. However, the existatus is always 1, and it means the resources are always failed to start to run.

Run if [ "$exitstatus" -eq 1 ];then
  if [ "$exitstatus" -eq 1 ];then
      exit 1
  fi
  shell: /usr/bin/bash -e {0}
  env:
    MINIKUBE_HOME: /home/runner/work/_temp
    exitstatus: 1
Error: Process completed with exit code 1.

Desired Behavior

The runresources step should be more reliable

Implementation

Acceptance Tests

---

Contributor Guides and Resources

• 📝 Meshery Adapters Spreadsheet
• 🛠 Meshery Build & Release Strategy
• 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

[Aisuko]

https://layer5io.slack.com/archives/C011VPREG2Z/p1696837655199399

[yash37158]

Hey @Aisuko, to address the reliability issue and ensure that it is correctly handled we can handle the resource status check. by assuming that we want to check the status of multiple resources and mark the workflow as failed if any critical resource fails while still allowing the workflow to continue in other cases.

This approach should make our workflow more reliable and better handle resource status checks while allowing us to continue with the workflow in cases where some non-critical resources might not be in the "Running" state.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.