Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Istio-vet to validate Istio config before applying it on the mesh #21

Closed
girishranganathan opened this issue Jan 24, 2019 · 8 comments
Assignees

Comments

@girishranganathan
Copy link
Contributor

No description provided.

@leecalcote
Copy link
Member

meshery

@leecalcote
Copy link
Member

Potentially of interest, @venilnoronha?

@venilnoronha
Copy link
Contributor

@leecalcote yes, thanks!

@venilnoronha
Copy link
Contributor

I've created PR meshery/meshery-istio#6 to address this.

@nrjpoddar
Copy link

Hi @leecalcote, can we jump on a short meeting to discuss how meshery can use istio-vet & also enhancements you would like to see in istio-vet?

@venilnoronha
Copy link
Contributor

@nrjpoddar I believe istio-vet does a runtime analysis of the environment. Can it do a static analysis of Istio yaml configuration?

@nrjpoddar
Copy link

Yes, that is correct. Istio currently provides static analysis logic in istioctl, galley & pilot which are scattered all over and we didn't want to copy that logic again in istio-vet.

I believe static analysis belongs in galley and/or istioctl. As galley is registered as admission webhook it can reject invalid configuration.

@leecalcote
Copy link
Member

Hi @nrjpoddar, yes, it'd be great to collaborate with you here. Your guidance and counsel on the approach to the integration would be ideal. If convenient, we hold a weekly community meeting on Fridays at 2pm Central (currently). Details here - https://layer5.io/meshery/#contributing

If this time doesn't work, yes, let's catch up separately. There's a community slack here - http://slack.layer5.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants